chore: refactor ci config #207
Conversation
WalkthroughThe updates involve configuration changes for ESLint and Playwright. ESLint configurations now import custom settings from a shared package and apply them, while Playwright configurations have been simplified by extending a base configuration from another package. These changes streamline the setup process and enforce consistent coding and testing standards across projects. Changes
Poem
TipsChat with CodeRabbit Bot (
|
Deploying with
|
| Latest commit: |
90ef9c3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4977a45f.sentry-sveltekit-cloudflare.pages.dev |
| Branch Preview URL: | https://dev.sentry-sveltekit-cloudflare.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to filter (3)
- demo/package.json
- package.json
- pnpm-lock.yaml
Files selected for processing (3)
- demo/eslint.config.js (1 hunks)
- eslint.config.js (1 hunks)
- playwright.config.ts (1 hunks)
Additional comments: 4
demo/eslint.config.js (1)
- 1-4: The changes to the ESLint configuration file are correct and follow the intended refactoring to use a shared configuration package. Ensure that dependents are aware of the new linting rules and adjust their code if necessary.
playwright.config.ts (3)
1-1: The import statement has been changed to use
extendsConfigfrom@jill64/playwright-config. Verify that this package provides all the necessary configurations and is compatible with the project's requirements.5-12: The new configuration is significantly simplified and no longer includes specific settings such as
testDir,fullyParallel,workers,retries, andprojects. Ensure that these settings are provided byextendsConfigor are no longer required for the project.7-10: The
baseURLis dynamically set based on theGITHUB_REF_NAMEenvironment variable. Confirm that the branches are correctly set up to serve the application for this configuration to work as intended.
| export default [ | ||
| ...tsConfig(), | ||
| { | ||
| ignores: ['tests', 'demo', 'scripts'] |
There was a problem hiding this comment.
The ESLint configuration property for specifying patterns to ignore should be ignorePatterns, not ignores.
- ignores: ['tests', 'demo', 'scripts']
+ ignorePatterns: ['tests', 'demo', 'scripts']Committable suggestion
❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| ignores: ['tests', 'demo', 'scripts'] | |
| ignorePatterns: ['tests', 'demo', 'scripts'] |
Summary by CodeRabbit
Refactor
Chores